1996fanrui commented on code in PR #29191:
URL: https://github.com/apache/flink/pull/29191#discussion_r4036286844
##########
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/UnknownInputChannel.java:
##########
@@ -192,6 +192,8 @@ public RemoteInputChannel toRemoteInputChannel(
metrics.getNumBytesInRemoteCounter(),
metrics.getNumBuffersInRemoteCounter(),
channelStateWriter == null ? ChannelStateWriter.NO_OP
: channelStateWriter,
+ // Unknown channels exist only in BATCH jobs, which
have no channel
Review Comment:
Hey @davidradl , I received some code review offline, and it mentioned that
`needsRecovery is always false` in `UnknownInputChannel` is a risk that
potentially missing the recovery path.
After analysis, the `Unknown channels exist only in BATCH jobs`, so this
risk does not actually apply.
I’m inclined to add some documentation comments here to clarify this,
ensuring that AI or developers can correctly understand the situation quickly,
and avoid confusion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
