minxhe commented on code in PR #29109: URL: https://github.com/apache/flink/pull/29109#discussion_r4021212942
########## flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/SavepointRestoreSettings.java: ########## Review Comment: You're right — I missed the application graph reconstruction, so the session-only limitation was incorrect. Fixed in f2142942f7215e79f37e637274b3c869fe3f77d4: shared `fromConfiguration()` now preserves explicit pathless modes, nullable allow settings, and the deprecated configuration alias with canonical-key precedence. FLINK-40562 is the same reconstruction issue and is included here; I've corrected the PR description. Ran the settings, graph-generator, CLI, and container parser suites on JDK 17: 109 tests passed, plus Spotless and Checkstyle. Coverage includes `ProgramOptions` → `ExecutionConfigAccessor` and graph settings before and after `PipelineExecutorUtils`; settings and generator regression cases failed before the fix and passed afterward. I haven't run live-cluster failover scenarios, and this does not override already-persisted HA graphs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
