Jackeyzhe commented on code in PR #29109: URL: https://github.com/apache/flink/pull/29109#discussion_r3990503749
########## flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/SavepointRestoreSettings.java: ########## Review Comment: Could we also preserve the pathless claim mode through `SavepointRestoreSettings.fromConfiguration` in this change? The round trip appears to affect application mode as well, not only session mode. `StandaloneApplicationClusterEntryPoint.loadConfigurationFromClusterConfig` writes CLAIM to the configuration, but `StreamGraphGenerator` reads the settings back through `fromConfiguration`. The application submission path also calls `PipelineExecutorUtils.getStreamGraph`, which reads them through `ExecutionConfigAccessor` and sets them on the graph. With no savepoint path, `fromConfiguration` returns `none()`, so the graph ends up with NO_CLAIM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
