rob-9 commented on code in PR #1005:
URL: https://github.com/apache/flink-agents/pull/1005#discussion_r3798483806
##########
docs/content/docs/development/yaml.md:
##########
@@ -208,13 +208,14 @@ agents:
key: tenant_id
```
-**Skills** — bundles of agent skill assets loaded from one or more sources. At
least one of `paths` / `urls` / `classpath` / `package` must be non-empty;
multiple sources can coexist.
+**Skills** — bundles of agent skill assets loaded from one or more sources. At
least one of `paths` / `urls` / `url_sources` / `classpath` / `package` must be
non-empty; multiple sources can coexist.
| Field | Required | Description |
|-------|----------|-------------|
| `name` | yes | Skills resource name. |
| `paths` | one-of | `local` scheme: list of directories or `.zip` files. |
-| `urls` | one-of | `url` scheme: list of `http(s)` URLs pointing to `.zip`
archives. |
+| `urls` | one-of | `url` scheme: list of HTTPS URLs pointing to `.zip`
archives. |
Review Comment:
probably both. the migration path belongs in the YAML docs, while the
compatibility change belongs in release notes. I added the YAML migration
example here.
##########
api/src/test/java/org/apache/flink/agents/api/skills/SkillsResourceTest.java:
##########
@@ -65,6 +122,16 @@ void roundTripsThroughJackson() throws Exception {
assertEquals(original.getSources(), restored.getSources());
}
+ @Test
+ void pinnedUrlRoundTripsThroughJackson() throws Exception {
Review Comment:
agreed. extended both round-trip tests to cover `allow_insecure_http` and
verify it remains the string `"true"` thru serialization and deserialization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
