rob-9 commented on code in PR #1005:
URL: https://github.com/apache/flink-agents/pull/1005#discussion_r3798482243
##########
api/src/main/java/org/apache/flink/agents/api/yaml/YamlLoader.java:
##########
@@ -173,8 +174,19 @@ public static Skills buildSkills(SkillsSpec spec) {
for (String p : spec.getPaths()) {
sources.add(new SkillSourceSpec("local", Map.of("path", p)));
}
- for (String u : spec.getUrls()) {
- sources.add(new SkillSourceSpec("url", Map.of("url", u)));
+ for (String url : spec.getUrls()) {
+ sources.add(new SkillSourceSpec("url", Map.of("url", url)));
Review Comment:
it wasn't deliberate. both YAML loaders now use the validated URL factories,
so plain HTTP and malformed digests fail during loading while explicit HTTP
opt-in remains supported.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
