hulincup commented on code in PR #962:
URL: https://github.com/apache/flink-agents/pull/962#discussion_r3717294885
##########
python/flink_agents/api/yaml/tests/test_aliases.py:
##########
@@ -127,6 +127,36 @@ def test_resolve_clazz_default_language_is_python() ->
None:
assert default == explicit
+def test_resolve_clazz_covers_chat_model_java_gemini_and_azure_openai() ->
None:
+ assert resolve_clazz("gemini", ResourceType.CHAT_MODEL_CONNECTION,
"java").endswith(
+ "GeminiChatModelConnection"
+ )
+ assert resolve_clazz("gemini", ResourceType.CHAT_MODEL, "java").endswith(
+ "GeminiChatModelSetup"
+ )
+ assert resolve_clazz(
+ "azure_openai", ResourceType.CHAT_MODEL_CONNECTION, "java"
+ ).endswith("AzureOpenAIChatModelConnection")
Review Comment:
Good catch — done in 78b8328. `azure_openai` now asserts both
`startswith("org.apache.flink.agents")` and `endswith(...)` on the connection
and the setup, mirroring `test_resolve_clazz_dispatches_on_language`. `13
passed` locally, including
`test_resolve_clazz_covers_chat_model_java_gemini_and_azure_openai`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
