weiqingy commented on PR #962: URL: https://github.com/apache/flink-agents/pull/962#issuecomment-5175193089
One note on the body: GitHub's closing-keyword parser stops at the number, so `Closes #958 (item 1).` doesn't actually scope to item 1. Merging would close all of #958, taking item 2 and the still-open question about whether any of the six should stay deliberately unaliased along with it. Would `Part of #958 (item 1).` do the job here? Same link, minus the auto-close. One other thing worth folding in: the repo keeps a PR template at `.github/PULL_REQUEST_TEMPLATE.md` asking for a `Linked issue:` line plus `### Purpose of change`, `### Tests`, `### API`, and `### Documentation`. Easy to miss, since GitHub only pre-fills it when you open the PR through the web form. Your body already covers most of it, so it's mostly remapping headings, and `doc-included` looks like the right box given the `yaml.md` change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
