weiqingy commented on PR #930: URL: https://github.com/apache/flink-agents/pull/930#issuecomment-5172738898
@wenjin272 Thanks for the review. I have updated the PR to address the three comments, could you take another look? On the experiment feedback, this is useful from a single PR. I agree it was too detailed, though I suspect the cause was my prompt rather than the format itself. I had told the agent to make the description self-contained so a reviewing agent would only need one document. That optimized for machines and made it unreadable for humans: 24k characters for a 1,232-line diff. That rule is gone now. The description is the PR body, and #952 is the corrected sample: 123 lines, around 6k characters. Curious whether it reads better to you. I also agree on scaling detail to size and risk. Maybe a rule along these lines: - Keep failure behavior and the contracts-to-tests mapping at any size, since those are properties of the finished code that a design-intent Spec tends to leave out. - Add the runtime-flow narration only for large or cross-cutting changes, since on a focused PR it mostly restates the diff. Does that split match what you had in mind, or would you draw the line differently? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
