applike-ss commented on code in PR #1163:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/1163#discussion_r3674604113
##########
helm/flink-kubernetes-operator/templates/_helpers.tpl:
##########
@@ -89,3 +89,10 @@ Supported values for .Values.logging.framework: "log4j2"
(default), "logback".
-Dlog4j.configurationFile=/opt/flink/conf/log4j-operator.properties
{{- end -}}
{{- end }}
+
+{{/*
+Create the name of the webhook certificate secret.
+*/}}
+{{- define "flink-operator.webhookCertSecretName" -}}
+{{- default (printf "%s-webhook-server-cert" .Release.Name)
.Values.webhook.certSecretName }}
Review Comment:
Updated and pushed the requested changes in a942d42e: the webhook
certificate Secret is now statically named
`flink-operator-webhook-server-cert`, the configurability and helper were
removed, all documentation and diagram references were updated, and the diagram
alignment was corrected. Could you please re-review the updated changes when
you have a chance?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
