Dennis-Mircea commented on code in PR #1163:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/1163#discussion_r3674239333
##########
helm/flink-kubernetes-operator/templates/_helpers.tpl:
##########
@@ -89,3 +89,10 @@ Supported values for .Values.logging.framework: "log4j2"
(default), "logback".
-Dlog4j.configurationFile=/opt/flink/conf/log4j-operator.properties
{{- end -}}
{{- end }}
+
+{{/*
+Create the name of the webhook certificate secret.
+*/}}
+{{- define "flink-operator.webhookCertSecretName" -}}
+{{- default (printf "%s-webhook-server-cert" .Release.Name)
.Values.webhook.certSecretName }}
Review Comment:
The default secret name changes from `webhook-server-cert` to
`<release-name>-webhook-server-cert`. On `helm upgrade` of an existing install,
cert-manager provisions a new secret under the new name and the deployment
rolls to it, so it self-heals, but the old `webhook-server-cert` secret is left
orphaned, and anything external that referenced the old name breaks silently.
Still, I do not see a valid reason to make this certificate configurable at
this extent. I'd say using `flink-operator-webhook-server-cert` as the
certificate name is sufficient to uniquely identify it within the namespace and
to avoid any collision.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
