joeyutong commented on code in PR #860:
URL: https://github.com/apache/flink-agents/pull/860#discussion_r3548797165
##########
runtime/src/main/java/org/apache/flink/agents/runtime/python/utils/PythonResourceAdapterImpl.java:
##########
@@ -200,6 +203,11 @@ public Object callMethod(Object obj, String methodName,
Map<String, Object> kwar
return interpreter.invoke(CALL_METHOD, obj, methodName, kwargs);
}
+ @Override
+ public void setMetricGroup(Object pythonResource, FlinkAgentsMetricGroup
metricGroup) {
+ interpreter.invoke(SET_METRIC_GROUP, pythonResource, metricGroup);
Review Comment:
Thanks, that matches my understanding.
I agree that #860 can stay focused on the forward propagation path, and the
return-path / effective-scope behavior can be tracked separately.
@goutamadwant Since this PR already calls out that limitation, would you
mind filing a follow-up issue for it? That would make the remaining ownership
question easier to continue without blocking this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
