goutamadwant commented on PR #860: URL: https://github.com/apache/flink-agents/pull/860#issuecomment-4912071327
@weiqingy @joeyutong Pushed an update addressing the review comments. The base Resource class no longer depends on the Python bridge. Metric forwarding now lives in the Python-backed wrappers, which call super.setMetricGroup(...) and then forward to the wrapped Python resource. I also added direct coverage for python_java_utils.set_metric_group(...), including the raw Java group wrapping path and the None path. On the Python-to-Java side, set_java_resource_metric_group(...) now accepts only FlinkMetricGroup or None and raises a clear TypeError for unsupported custom metric groups. I also updated the PR description to make the scope explicit: this PR handles forward metric-group propagation and keeps token recording single-recorder/no double-counting. The return-path/effective-scope behavior is still separate follow-up work. Let me know if you have any suggestions. thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
