SteveStevenpoor commented on PR #28671: URL: https://github.com/apache/flink/pull/28671#issuecomment-4911337586
> Hi @SteveStevenpoor , thanks for the review. If you have any other questions, please feel free to contact me Thanks for your contribution @Au-Miner. The newly added tests look great. Though, I still have a concern. Suppose the first three records in the bundle are +I -U +U. In this case: - JoinKeyContainsUniqueKeyBundle results in +I - InputSideHasUniqueKeyBundle results in +I - InputSideHasNoUniqueKeyBundle results in +U I understand that we usually treat +I and +U the same in many situations. However, if the first +U is not a problem for the NoUniqueKey case, why is it important in the other cases? I’m also concerned that this could be confusing for users, because the resulting record’s RowKind would depend on the joined table configuration. That’s my only remaining concern. Please let me know what you think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
