Au-Miner commented on code in PR #28671:
URL: https://github.com/apache/flink/pull/28671#discussion_r3540994844
##########
flink-table/flink-table-runtime/src/test/java/org/apache/flink/table/runtime/operators/join/stream/StreamingMiniBatchJoinOperatorTest.java:
##########
@@ -564,6 +564,73 @@ void
testInnerJoinWithJoinKeyContainsUniqueKeyCrossBatches() throws Exception {
"TRUCK"));
}
+ @Tag("miniBatchSize=4")
+ @Test
+ void
testInnerJoinWithJoinKeyContainsUniqueKeyInsertThenUpdateAfterFoldEmitsInsert()
Review Comment:
New tests have been added, including
`testInnerJoinWithJoinKeyContainsUniqueKeyUpdateBeforeThenUpdateAfterKeepsUpdateAfter`,
`testInnerJoinWithHasUniqueKeyUpdateBeforeThenUpdateAfterKeepsUpdateAfter`,
and `testInnerJoinWithNoUniqueKeyUpdateBeforeThenUpdateAfterKeepsUpdateAfter`,
with miniBatchSize=2, to verify whether the second bundle is not incorrectly
converted to +I
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
