twalthr commented on code in PR #28675:
URL: https://github.com/apache/flink/pull/28675#discussion_r3536611484
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/calcite/FlinkCalciteSqlValidator.java:
##########
@@ -456,6 +460,39 @@ private static void
checkNoNamedAndPositionalMixedArgs(SqlBasicCall call) {
}
}
+ /**
+ * Rejects the implicit PTF system arguments (on_time, uid) for functions
that disable them.
+ *
+ * <p>When a PTF sets {@code disableSystemArguments(true)}, the system
arguments are not part of
+ * its signature. Enforcing this here covers all translation paths
uniformly.
+ */
+ private static void checkDisabledSystemArgs(SqlBasicCall call) {
Review Comment:
I'm wondering why you choose this code location? Is SystemTypeInference not
good enough? Changes to `FlinkCalciteSqlValidator` should be kept minimal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
