fhueske opened a new pull request, #28675:
URL: https://github.com/apache/flink/pull/28675

   ## What is the purpose of the change
   
   Add a check in SqlValidator to reject PTF calls with system-args (`on_time`, 
`uid`) if the function disabled them.
   Before, system-args were either accepted but ignored (custom implementation 
like MLPredict) or the generic PTF handling framework throws an exception later 
(this part is untouched because the execution framework expects these args in 
the function signature even if not set).
   
   ## Brief change log
   
   * add check to `FlinkCalciteSqlValidator`
   * add unit tests to `ProcessTableFunctionTest`
   * add unit tests for `MLPredict` function
   
   ## Verifying this change
   
   Added unit tests.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? n/A
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes (please specify the tool below)
   
   Generated-by: Claude Code 2.1.200 (Opus 4.8)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to