twalthr commented on code in PR #28510:
URL: https://github.com/apache/flink/pull/28510#discussion_r3518349407
##########
flink-table/flink-sql-gateway/src/test/java/org/apache/flink/table/gateway/service/MaterializedTableStatementITCase.java:
##########
@@ -1100,6 +1057,100 @@ void testAlterMaterializedTableAsQueryInFullMode()
throws Exception {
assertThat(oldTable.getDefinitionFreshness()).isEqualTo(newTable.getDefinitionFreshness());
}
+ @Test
+ void
testCreateOrAlterMaterializedTableColumnListReordersSchemaOnCreatePath() throws
Exception {
Review Comment:
Those tests seem unrelated to the EXPLAIN. We can keep them, just wanted to
double check why they are here.
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/stream/sql/TableSinkTest.scala:
##########
@@ -929,6 +929,146 @@ class TableSinkTest extends TableTestBase {
assertEquals(TableTestUtil.replaceStageId(expected),
TableTestUtil.replaceStageId(actual))
}
+ @Test
+ def testExplainCreateMaterializedTable(): Unit = {
Review Comment:
nit: we should not check-in more Scala code. This can be a new class in Java.
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/materializedtable/AlterMaterializedTableAsQueryOperation.java:
##########
@@ -40,8 +41,9 @@ public class AlterMaterializedTableAsQueryOperation extends
AlterMaterializedTab
public AlterMaterializedTableAsQueryOperation(
ObjectIdentifier tableIdentifier,
Function<ResolvedCatalogMaterializedTable, List<TableChange>>
tableChangesForTable,
- ResolvedCatalogMaterializedTable oldTable) {
- super(tableIdentifier, tableChangesForTable, oldTable);
+ ResolvedCatalogMaterializedTable oldTable,
+ QueryOperation sinkModifyQuery) {
Review Comment:
nit: for consistency we should have the name `Operation` in the variable
names. Can the class be more specific?
```suggestion
ModifyOperation sinkModifyOperation) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
