raminqaf commented on code in PR #28510:
URL: https://github.com/apache/flink/pull/28510#discussion_r3498787396
##########
flink-table/flink-sql-parser/src/test/java/org/apache/flink/sql/parser/FlinkSqlParserImplTest.java:
##########
@@ -3184,29 +3170,40 @@ void testAnalyzeTable() {
.fails("(?s).*Encountered \"\\,\" at line 1, column 32.\n.*");
}
- @Test
- void testExplainCreateTableNoSupported() {
- this.sql("EXPLAIN CREATE TABLE t (id int^)^")
+ @ParameterizedTest
+ @CsvSource({"CREATE", "CREATE OR REPLACE"})
+ void testExplainCreateTableNotSupported(final String operation) {
+ this.sql(String.format("EXPLAIN %s TABLE t (id int^)^", operation))
.fails(
"Unsupported CREATE OR REPLACE statement for
EXPLAIN\\. The statement must define a query using the AS clause \\(i\\.e\\.
CTAS/RTAS statements\\)\\.");
}
- @Test
- void testExplainCreateTableAsSelect() {
- this.sql("EXPLAIN CREATE TABLE t AS SELECT * FROM b")
- .ok("EXPLAIN CREATE TABLE `T`\nAS\nSELECT *\nFROM `B`");
- }
-
- @Test
- void testExplainCreateOrReplaceTableAsSelect() {
- this.sql("EXPLAIN CREATE OR REPLACE TABLE t AS SELECT * FROM b")
- .ok("EXPLAIN CREATE OR REPLACE TABLE `T`\nAS\nSELECT *\nFROM
`B`");
+ @ParameterizedTest
+ @CsvSource({
Review Comment:
Chnaged the tests to use `@ValueSource(strings = {...})`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
