snuyanzin commented on code in PR #28170:
URL: https://github.com/apache/flink/pull/28170#discussion_r3416830748
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/calcite/FlinkTypeSystem.java:
##########
@@ -100,6 +100,16 @@ public int getMaxPrecision(SqlTypeName typeName) {
return super.getMaxPrecision(typeName);
}
+ @Override
+ public int getMinScale(SqlTypeName typeName) {
Review Comment:
implicitly it was supported before and in Flink there is even a test for ths
https://github.com/apache/flink/blob/d70e596602b6211a415be40edab9a0f7bc7328dd/flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/serde/RelDataTypeJsonSerdeTest.java#L94-L101
the issue is that by default Calcite sets min scale to 0 for DECIMAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
