snuyanzin commented on code in PR #28170: URL: https://github.com/apache/flink/pull/28170#discussion_r3409382443
########## flink-table/flink-table-planner/src/main/java/org/apache/calcite/sql/type/BasicSqlType.java: ########## @@ -0,0 +1,322 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to you under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.calcite.sql.type; + +import org.apache.calcite.rel.type.RelDataTypeSystem; +import org.apache.calcite.sql.SqlCollation; +import org.apache.calcite.util.SerializableCharset; +import org.checkerframework.checker.nullness.qual.Nullable; + +import java.nio.charset.Charset; + +import static com.google.common.base.Preconditions.checkArgument; +import static java.util.Objects.requireNonNull; + +/** + * BasicSqlType represents a standard atomic SQL type (excluding interval types). + * + * <p>Instances of this class are immutable. + */ +public class BasicSqlType extends AbstractSqlType { Review Comment: The reason this class is here https://issues.apache.org/jira/browse/CALCITE-7531 where isNullable in `AbstractSqlType` became final and there no any constructor taking it as an arg. fixed in Calcite 1.42.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
