wenjin272 commented on PR #655:
URL: https://github.com/apache/flink-agents/pull/655#issuecomment-4485909320
Hi, @wzhero1. Ty for the careful review.
I have updated and addressed the second round comments:
- **`owned` rename + 5× delegating boilerplate**: the three repos
collapsed into `AbstractMaterializedSkillRepository` (Java) /
`MaterializedSkillRepository` (Python); the
field becomes `materialization` on the base. Python's
`PackageSkillRepository` simplified to own its tempdir (no more `as_file` ctx +
atexit two-step). — 7152f9e2
- **`originOf` scheme ladder**: moved onto
`SkillSourceHandler.describeLocation`; built-ins register both functions
together. Dead `case "package"` is gone. — e20359eb
- **Partial-load repo leak + `close()` swallow**: constructor closes
already-registered repos before propagating; close cascade aligned with
`ResourceCache.close()`
(first-exception rethrow + suppressed). — 1c16c86a
- **`@Skills` merge non-determinism**: `addSkills` sorts keys lexically
before merging; mixed-scheme test re-asserts as `List` to lock the order. —
8c2fe46c
- **`AgentSkill` JSON asymmetry**: not taking — see inline reply.
Six of seven taken; cross-language symmetry preserved on every fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
