wenjin272 commented on code in PR #655:
URL: https://github.com/apache/flink-agents/pull/655#discussion_r3264374788
##########
runtime/src/main/java/org/apache/flink/agents/runtime/skill/AgentSkill.java:
##########
@@ -44,6 +44,7 @@ public final class AgentSkill {
@Nullable private volatile Map<String, String> resources;
@Nullable private Supplier<Map<String, String>> resourceLoader;
private volatile boolean activated;
+ @Nullable private volatile SkillOrigin origin;
Review Comment:
Took a closer look and decided to skip this for now. Grep'd every
`AgentSkill` reference in the repo (Java + Python) — no serialization path uses
it today, and Jackson's
default bean introspection would emit `getOrigin()` as `"origin"`
automatically even without the annotation, so the "silently drops" failure mode
doesn't actually fire under
the project's default `ObjectMapper`.
Also worth noting: I ran Python's `model_dump()` and it emits `"origin":
null` by default (pydantic v2 doesn't drop None fields), so
`@JsonInclude(NON_NULL)` would have made
the two sides byte-asymmetric. I'd rather design the schema (NON_NULL vs
null, `resources` handling, `@JsonCreator`) when there's an actual wire path
with concrete
requirements. Happy to revisit if you have a specific path in mind.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
