Samrat002 commented on code in PR #27788:
URL: https://github.com/apache/flink/pull/27788#discussion_r3214470360
##########
flink-filesystems/flink-s3-fs-native/src/main/java/org/apache/flink/fs/s3native/NativeS3FileSystemFactory.java:
##########
@@ -337,7 +385,6 @@ public FileSystem create(URI fsUri) throws IOException {
final long s3minPartSize = config.get(PART_UPLOAD_MIN_SIZE);
final int maxConcurrentUploads = config.get(MAX_CONCURRENT_UPLOADS);
- // Validate part size: S3 requires minimum 5MB and maximum 5GB per part
Review Comment:
Reverted — the inline validation comments were also scope-creep edits; the
original master text (with the `// Validate part size: S3 requires minimum 5MB
and maximum 5GB per part` and `// Validate and clamp read buffer size`
comments) is restored.
##########
flink-filesystems/flink-s3-fs-native/src/main/java/org/apache/flink/fs/s3native/NativeS3FileSystemFactory.java:
##########
@@ -356,8 +403,6 @@ public FileSystem create(URI fsUri) throws IOException {
boolean useAsyncOperations = config.get(USE_ASYNC_OPERATIONS);
- // Validate and clamp read buffer size to sensible range [64KB, 4MB]
- // We clip rather than throw to provide flexibility while preventing
extreme values
Review Comment:
Reverted — same as above; original master text restored.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
