Samrat002 commented on code in PR #27788:
URL: https://github.com/apache/flink/pull/27788#discussion_r3214470069
##########
flink-filesystems/flink-s3-fs-native/src/main/java/org/apache/flink/fs/s3native/NativeS3FileSystemFactory.java:
##########
@@ -190,15 +195,14 @@ public class NativeS3FileSystemFactory implements
FileSystemFactory {
+ "Example:
'arn:aws:kms:us-east-1:123456789:key/12345678-1234-1234-1234-123456789abc' "
+ "or 'alias/my-s3-key'");
- // IAM Assume Role Configuration
public static final ConfigOption<String> ASSUME_ROLE_ARN =
ConfigOptions.key("s3.assume-role.arn")
.stringType()
.noDefaultValue()
.withDescription(
"ARN of the IAM role to assume for S3 access. "
- + "Enables cross-account access or
temporary elevated permissions. "
- + "Example:
'arn:aws:iam::123456789012:role/S3AccessRole'");
+ + "Examples:
'arn:aws:iam::123456789012:role/S3AccessRole' (aws), "
+ +
"'arn:aws-cn:iam::123456789012:role/S3AccessRole' (aws-cn)");
Review Comment:
Reverted — the description change was a scope-creep edit; the original
master text is restored.
##########
flink-filesystems/flink-s3-fs-native/src/main/java/org/apache/flink/fs/s3native/NativeS3FileSystemFactory.java:
##########
@@ -190,15 +195,14 @@ public class NativeS3FileSystemFactory implements
FileSystemFactory {
+ "Example:
'arn:aws:kms:us-east-1:123456789:key/12345678-1234-1234-1234-123456789abc' "
+ "or 'alias/my-s3-key'");
- // IAM Assume Role Configuration
Review Comment:
Reverted — the description change was a scope-creep edit; the original
master text is restored.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
