[
https://issues.apache.org/jira/browse/FLINK-5559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15832013#comment-15832013
]
ASF GitHub Bot commented on FLINK-5559:
---------------------------------------
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/3172#discussion_r97100430
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/query/netty/message/KvStateRequestSerializer.java
---
@@ -377,22 +376,24 @@ public static Throwable
deserializeServerFailure(ByteBuf buf) throws IOException
0,
serializedKeyAndNamespace.length);
- K key = keySerializer.deserialize(dis);
- byte magicNumber = dis.readByte();
- if (magicNumber != 42) {
- throw new IllegalArgumentException("Unexpected magic
number " + magicNumber +
- ". This indicates a mismatch in the key
serializers used by the " +
- "KvState instance and this access.");
- }
- N namespace = namespaceSerializer.deserialize(dis);
+ try {
+ K key = keySerializer.deserialize(dis);
+ byte magicNumber = dis.readByte();
+ if (magicNumber != 42) {
--- End diff --
This was an historic artifact of the Flink 1.1 key and namespace
serialization with RocksDB. I think we can remove this completely in a
different issue.
> queryable state: KvStateRequestSerializer#deserializeKeyAndNamespace() throws
> an IOException without own failure message if deserialisation fails
> -------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: FLINK-5559
> URL: https://issues.apache.org/jira/browse/FLINK-5559
> Project: Flink
> Issue Type: Improvement
> Components: Queryable State
> Affects Versions: 1.2.0
> Reporter: Nico Kruber
> Assignee: Nico Kruber
> Priority: Minor
>
> KvStateRequestSerializer#deserializeKeyAndNamespace() throws an IOException,
> e.g. EOFException, if the deserialisation fails, e.g. there are not enough
> available bytes.
> In these cases, it should instead also throw an IllegalArgumentException with
> a message containing "This indicates a mismatch in the key/namespace
> serializers used by the KvState instance and this access." as the other error
> cases.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
