[ 
https://issues.apache.org/jira/browse/FLINK-5559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15829996#comment-15829996
 ] 

ASF GitHub Bot commented on FLINK-5559:
---------------------------------------

GitHub user NicoK opened a pull request:

    https://github.com/apache/flink/pull/3172

    [FLINK-5559] let KvStateRequestSerializer#deserializeKeyAndNamespace() 
throw a proper IOException

    This adds the hint that a deserialisation failure probably results from a 
`"mismatch in the key/namespace serializers used by the KvState instance and 
this access"` to all thrown exceptions and throws proper `IOException` 
instances instead of `IllegalArgumentException`.
    
    The new unit tests require #3171 to be accepted first on which this PR is 
also based.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/NicoK/flink flink-5559

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3172.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3172
    
----

----


> queryable state: KvStateRequestSerializer#deserializeKeyAndNamespace() throws 
> an IOException without own failure message if deserialisation fails
> -------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: FLINK-5559
>                 URL: https://issues.apache.org/jira/browse/FLINK-5559
>             Project: Flink
>          Issue Type: Improvement
>          Components: Queryable State
>    Affects Versions: 1.2.0
>            Reporter: Nico Kruber
>            Assignee: Nico Kruber
>            Priority: Minor
>
> KvStateRequestSerializer#deserializeKeyAndNamespace() throws an IOException, 
> e.g. EOFException, if the deserialisation fails, e.g. there are not enough 
> available bytes.
> In these cases, it should instead also throw an IllegalArgumentException with 
> a message containing "This indicates a mismatch in the key/namespace 
> serializers used by the KvState instance and this access." as the other error 
> cases.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to