yuxiqian commented on code in PR #4199:
URL: https://github.com/apache/flink-cdc/pull/4199#discussion_r2964554999
##########
flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/operators/transform/PostTransformOperatorBuilder.java:
##########
@@ -67,6 +90,7 @@ public PostTransformOperatorBuilder addTransform(
"",
"",
"",
+ "",
Review Comment:
The default field for `tableOptionsDelimiter` is inconsistent. It is `,` in
TransformDef, `null` in an `addTransform` method and `""` in another
`addTransform` method.
##########
flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/operators/transform/SchemaMetadataTransform.java:
##########
@@ -58,13 +61,19 @@ public SchemaMetadataTransform(
partitionKeys = Arrays.asList(partitionKeyArr);
}
if (!StringUtils.isNullOrWhitespaceOnly(tableOptionString)) {
- for (String tableOption : tableOptionString.split(",")) {
- String[] kv = tableOption.split("=");
+ // Use custom delimiter if provided, otherwise default to comma
for backward
+ // compatibility.
+ String delimiter =
+ StringUtils.isNullOrWhitespaceOnly(tableOptionsDelimiter)
Review Comment:
I'm not quite sure about the `isNullOrWhitespaceOnly` check. Sometimes using
`\n` as delimiter might make sense, allowing such clearer syntax:
```
table-options: |-
k1=v1
k2=v2
table-options.delimiter: '\n'
```
Anyway, adding logs here would be nice as it's error-prone.
##########
docs/content.zh/docs/core-concept/transform.md:
##########
@@ -467,8 +474,8 @@ transform:
## Embedding AI 模型
-Embedding AI 模型可以在 transform 规则中使用。
-为了使用 Embedding AI 模型，你需要下载内置模型的 jar，然后在 `flink-cdc.sh` 命令中添加 `--jar
{$BUILT_IN_MODEL_PATH}`。
+内置AI模型可以在transform规则中使用。
+为了使用内置AI模型，你需要下载内置模型的jar，然后在flink-cdc.sh命令中添加`--jar {$BUILT_IN_MODEL_PATH}`。
Review Comment:
```suggestion
内置 AI 模型可以在 transform 规则中使用。
为了使用内置 AI 模型，你需要下载内置模型的 jar ，然后在 `flink-cdc.sh` 命令中添加 `--jar
{$BUILT_IN_MODEL_PATH}`。
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
