yuxiqian commented on code in PR #4199:
URL: https://github.com/apache/flink-cdc/pull/4199#discussion_r2964566241
##########
flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/operators/transform/SchemaMetadataTransform.java:
##########
@@ -58,13 +61,19 @@ public SchemaMetadataTransform(
partitionKeys = Arrays.asList(partitionKeyArr);
}
if (!StringUtils.isNullOrWhitespaceOnly(tableOptionString)) {
- for (String tableOption : tableOptionString.split(",")) {
- String[] kv = tableOption.split("=");
+ // Use custom delimiter if provided, otherwise default to comma
for backward
+ // compatibility.
+ String delimiter =
+ StringUtils.isNullOrWhitespaceOnly(tableOptionsDelimiter)
Review Comment:
I'm not quite sure about the `isNullOrWhitespaceOnly` check. Sometimes using
`\n` as delimiter might make sense, allowing such clearer syntax:
```
table-options: |-
k1 = v1
k2 = v2
table-options.delimiter: "\n"
```
Anyway, adding logs here would be nice as it's error-prone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
