leonardBang commented on PR #212: URL: https://github.com/apache/flink-connector-kafka/pull/212#issuecomment-4020682305
> I agree this PR was merged too quickly, and could have waited a bit longer. The IT has been added in [cdbd635](https://github.com/apache/flink-connector-kafka/commit/cdbd635171fc4322ba7182eb93e920472d6d9d91). Thanks for adding an IT in a later PR, this makes the change look better. > For the other points, my understanding was: > * I was not aware of a requirement that non-architectural changes must be approved by another committer. In the past, I have seen non-committer approvals accepted for this type of change. For this PR, I also requested reviews from a couple committers based on activity at that time, but did not receive a response. I'm happy to include you or anyone else as reviewers in future if you can commit to timely reviewing them Flink community does not require non-architectural changes must be approved by another committer, but we suggested[1]. In this case, committer loserwang1024 comment that we need an **IT** case, but you reply that we've a **UT** case and merge the PR directly, That's why I point out this issue. Imaging that you're review other committer's PR and left one comment without resolved reply, and he/she merge the PR directly, what's your feeling for the community process? I think it should be a consensus that we should resolve other committers' comment if your PR is reviewing by them and other committer left reasonable comment. [1] Flink Committer Invitation Email template: Being a committer enables you to make changes without relying on other committers to commit your changes. However, we encourage you to keep the same approach to contributions and keep working with peer reviews. Think of the committer status as a recognition of your work in the community, that also gives you the ability to now execute the final step of a contribution (pushing to the Flink repositories) by yourself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
