bowenli86 commented on PR #212: URL: https://github.com/apache/flink-connector-kafka/pull/212#issuecomment-4017489772
Hi @leonardBang @ferenc-csaky, thanks for raising this. I agree this PR was merged too quickly, and could have waited a bit longer. The IT has been added in https://github.com/apache/flink-connector-kafka/commit/cdbd635171fc4322ba7182eb93e920472d6d9d91. For the other points, my understanding was: - For straightforward changes, the PR title and linked JIRA have generally been treated as sufficient context. For example, commits such as https://github.com/apache/flink-connector-kafka/commit/20ca57d7efdcca52b5ce44afbccc1e7ad66ff82b, https://github.com/apache/flink-connector-kafka/commit/f2e6b34ebfd7f6d91874cd8ee9b9563b22fa398d, https://github.com/apache/flink-connector-kafka/commit/a42f6a42928bba801bc75897470562debe4c50c4, https://github.com/apache/flink-connector-kafka/commit/e0969a4ba7b5e23500a68b5aea5824fffe4ed0fa and many more that do not include additional descriptions either. For more involved changes, I agree that a fuller description is beneficial, and that is what I have tried to provide in those cases - I was not aware of a requirement that non-architectural changes must be approved by another committer. In the past, I have seen non-committer approvals accepted for this type of change. For this PR, I also requested reviews from a couple committers based on activity at that time, but did not receive a response. I'm happy to include you or anyone else as reviewers in future if you can commit to timely reviewing them - This was not a blind approval. The JIRA and PR describe the motivation and proposed solution in details, comments were addressed (lots are done offline), and the change passed CI. It has been some time since I last committed, if the project’s routines or expectations have changed, please point me to the current standard. I fully support improving the process, e.g. if we want stricter requirements such as mandatory descriptions for all commits, that should be applied consistently to all commits across the repo -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
