davidradl commented on code in PR #27605:
URL: https://github.com/apache/flink/pull/27605#discussion_r2895884450
##########
flink-table/flink-sql-parser/src/test/java/org/apache/flink/sql/parser/FlinkSqlParserImplTest.java:
##########
@@ -2510,31 +2510,39 @@ void testCreateFunction() {
+ "system functions can only be registered as
temporary "
+ "functions, you can use CREATE TEMPORARY
SYSTEM FUNCTION instead.");
- // test creating functiosn with either jar or artifact
+ // test creating functions with either jar or artifact
for (String usageType : List.of("JAR", "ARTIFACT")) {
sql("create temporary function function1 as
'org.apache.flink.function.function1' language java using "
+ usageType
+ " 'file:///path/to/test.jar'")
.ok(
- "CREATE TEMPORARY FUNCTION `FUNCTION1` AS
'org.apache.flink.function.function1' LANGUAGE JAVA USING JAR
'file:///path/to/test.jar'");
+ "CREATE TEMPORARY FUNCTION `FUNCTION1` AS
'org.apache.flink.function.function1' LANGUAGE JAVA USING "
Review Comment:
I wonder if we could have a parameterized test passing params for the
different cases and expectations to avoid needing to have repeated CREATE
TEMPORARY FUNCTION
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
