twalthr commented on code in PR #27605:
URL: https://github.com/apache/flink/pull/27605#discussion_r2816839206
##########
flink-table/flink-sql-parser/src/main/codegen/includes/parserImpls.ftl:
##########
@@ -450,7 +450,7 @@ SqlCreate SqlCreateFunction(Span s, boolean replace,
boolean isTemporary) :
if ("SQL".equals(functionLanguage) ||
"PYTHON".equals(functionLanguage)) {
throw SqlUtil.newContextException(
functionLanguagePos,
-
ParserResource.RESOURCE.createFunctionUsingJar(functionLanguage));
+
ParserResource.RESOURCE.createFunctionUsingJarOrArtifact(functionLanguage));
Review Comment:
nit: I would also be fine to simplify the name
```suggestion
ParserResource.RESOURCE.createFunction(functionLanguage));
```
##########
docs/content.zh/docs/sql/hive-compatibility/hive-dialect/create.md:
##########
@@ -221,12 +221,12 @@ The function exists for the duration of the current
session.
```sql
CREATE FUNCTION [db_name.]function_name AS class_name
- [USING JAR 'file_uri'];
+ [USING JAR|ARTIFACT 'file_uri'];
Review Comment:
grammar is not 100% correct:
```suggestion
[USING [JAR|ARTIFACT] 'file_uri'];
```
##########
docs/content.zh/docs/sql/reference/ddl/create.md:
##########
@@ -876,7 +876,7 @@ CREATE [TEMPORARY] VIEW [IF NOT EXISTS]
[catalog_name.][db_name.]view_name
CREATE [TEMPORARY|TEMPORARY SYSTEM] FUNCTION
[IF NOT EXISTS] [[catalog_name.]db_name.]function_name
AS identifier [LANGUAGE JAVA|SCALA|PYTHON]
- [USING JAR '<path_to_filename>.jar' [, JAR '<path_to_filename>.jar']* ]
+ [USING JAR|ARTIFACT '<path_to_filename>.jar' [, JAR
'<path_to_filename>.jar']* ]
Review Comment:
please revisit this line, the grammar is not correct
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
