snuyanzin commented on code in PR #26954:
URL: https://github.com/apache/flink/pull/26954#discussion_r2874232599
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/operations/SqlDdlToOperationConverterTest.java:
##########
@@ -951,11 +950,15 @@ void testCreateTableWithFullDataTypes() {
final CalciteParser parser = getParserBySqlDialect(SqlDialect.DEFAULT);
SqlNode node = parser.parse(sql);
assertThat(node).isInstanceOf(SqlCreateTable.class);
- Operation operation =
- SqlNodeToOperationConversion.convert(planner, catalogManager,
node).get();
- TableSchema schema = ((CreateTableOperation)
operation).getCatalogTable().getSchema();
- Object[] expectedDataTypes = testItems.stream().map(item ->
item.expectedType).toArray();
- assertThat(schema.getFieldDataTypes()).isEqualTo(expectedDataTypes);
+ final Optional<Operation> convert =
Review Comment:
remove comment for this method
>// TODO: tweak the tests when FLINK-13604 is fixed.
since second bullet was fixed within
https://issues.apache.org/jira/browse/FLINK-20539
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
