snuyanzin commented on code in PR #26954:
URL: https://github.com/apache/flink/pull/26954#discussion_r2874210429
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CastFunctionITCase.java:
##########
@@ -795,7 +856,9 @@ private static List<TestSetSpec> allTypesBasic() {
// https://issues.apache.org/jira/browse/FLINK-24423
Continue using EPOCH
// date or use 0 for the year?
.fromCase(
- TIME(5), DEFAULT_TIME, LocalDateTime.of(1970,
1, 1, 12, 34, 56, 0))
+ TIME(5),
+ DEFAULT_TIME,
+ LocalDateTime.of(1970, 1, 1, 12, 34, 56,
123_000_000))
Review Comment:
it is fine
you can create a separate issue to support precision up to 9
however it will require a way more efforts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
