davidradl commented on code in PR #27599:
URL: https://github.com/apache/flink/pull/27599#discussion_r2813436352
##########
flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/FsStateChangelogWriter.java:
##########
@@ -140,6 +143,12 @@ class FsStateChangelogWriter implements
StateChangelogWriter<ChangelogStateHandl
private boolean closed;
+ /**
+ * Handles pinned (retained) per checkpoint to prevent premature discard
during truncation. Keyed
+ * by checkpointId, value is the list of handles that were retained for
that checkpoint.
+ */
+ private final TreeMap<Long, List<StreamStateHandle>>
checkpointPinnedHandles = new TreeMap<>();
Review Comment:
I am curious - do we need the values to have order? If not can we use a Set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
