davidradl commented on code in PR #27599:
URL: https://github.com/apache/flink/pull/27599#discussion_r2813397950
##########
flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/FsStateChangelogWriter.java:
##########
@@ -380,6 +394,21 @@ public void confirm(SequenceNumber from, SequenceNumber
to, long checkpointId) {
from,
to,
activeSequenceNumber);
+ // Unpin handles for this and all older checkpoints.
+ // Using stopTracking (not release) because JM has confirmed ownership.
+ NavigableMap<Long, List<StreamStateHandle>> toUnpin =
+ checkpointPinnedHandles.headMap(checkpointId, true);
+ if (!toUnpin.isEmpty()) {
+ LOG.debug(
Review Comment:
nits:
- enclose in if (log.isDebugEnabled())
- move the for into the if.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
