davidradl commented on code in PR #186:
URL:
https://github.com/apache/flink-connector-jdbc/pull/186#discussion_r2742161725
##########
flink-connector-jdbc-oceanbase/src/test/java/org/apache/flink/connector/jdbc/oceanbase/database/catalog/OceanBaseMysqlCatalogITCase.java:
##########
@@ -200,7 +200,7 @@ private static TableRow createTableAllTypeTable(String
tableName) {
DataTypes.DECIMAL(11, 0)),
field("col_double", dbType("double"), DataTypes.DOUBLE()),
field("col_double_unsigned", dbType("double unsigned"),
DataTypes.DOUBLE()),
- field("col_enum", dbType("enum('enum1','enum2','enum11')"),
DataTypes.VARCHAR(6)),
+ field("col_enum", dbType("enum('enum1','enum2','enum11')"),
DataTypes.CHAR(6)),
Review Comment:
@eskabetxe this field is changing an enum from a varchar(6) to a char(6).
The enum values are of length 5 or 6.
The PR text says : Changed the data type mapping for the col_enum field from
DataTypes.VARCHAR(6) to DataTypes.CHAR(6) in OceanBaseMysqlCatalogITCase.java
to better reflect the underlying database type. Please could you provide a
reference so we can see explicitly why this change is more appropriate. A
reference for the other case VARCHAR(18)) -> CHAR(18)), would be useful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
