eskabetxe commented on code in PR #186:
URL:
https://github.com/apache/flink-connector-jdbc/pull/186#discussion_r2740742141
##########
flink-connector-jdbc-oceanbase/src/test/java/org/apache/flink/connector/jdbc/oceanbase/database/catalog/OceanBaseMysqlCatalogITCase.java:
##########
@@ -200,7 +200,7 @@ private static TableRow createTableAllTypeTable(String
tableName) {
DataTypes.DECIMAL(11, 0)),
field("col_double", dbType("double"), DataTypes.DOUBLE()),
field("col_double_unsigned", dbType("double unsigned"),
DataTypes.DOUBLE()),
- field("col_enum", dbType("enum('enum1','enum2','enum11')"),
DataTypes.VARCHAR(6)),
+ field("col_enum", dbType("enum('enum1','enum2','enum11')"),
DataTypes.CHAR(6)),
Review Comment:
Hi @snuyanzin,
thanks for the review..
the varchar type is still there
field("col_varchar", dbType("varchar(255)"),
DataTypes.VARCHAR(255)),
Im only change the mapping for enum and set types, as it change on database
from version 4.2 to 4.3
Im not expert on OceanBase, maybe @whhe can give more details as it was
helping on previous
[PR](https://github.com/apache/flink-connector-jdbc/pull/184)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
