snuyanzin commented on code in PR #27199: URL: https://github.com/apache/flink/pull/27199#discussion_r2524002382
########## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/converters/SqlCreateOrAlterMaterializedTableConverter.java: ########## @@ -0,0 +1,262 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.planner.operations.converters; + +import org.apache.flink.sql.parser.ddl.SqlCreateOrAlterMaterializedTable; +import org.apache.flink.sql.parser.ddl.SqlTableColumn.SqlRegularColumn; +import org.apache.flink.table.api.Schema; +import org.apache.flink.table.api.ValidationException; +import org.apache.flink.table.catalog.CatalogBaseTable.TableKind; +import org.apache.flink.table.catalog.CatalogMaterializedTable; +import org.apache.flink.table.catalog.CatalogMaterializedTable.LogicalRefreshMode; +import org.apache.flink.table.catalog.CatalogMaterializedTable.RefreshMode; +import org.apache.flink.table.catalog.CatalogMaterializedTable.RefreshStatus; +import org.apache.flink.table.catalog.Column; +import org.apache.flink.table.catalog.IntervalFreshness; +import org.apache.flink.table.catalog.ObjectIdentifier; +import org.apache.flink.table.catalog.ResolvedCatalogBaseTable; +import org.apache.flink.table.catalog.ResolvedCatalogMaterializedTable; +import org.apache.flink.table.catalog.ResolvedSchema; +import org.apache.flink.table.catalog.TableChange; +import org.apache.flink.table.catalog.TableChange.MaterializedTableChange; +import org.apache.flink.table.catalog.TableDistribution; +import org.apache.flink.table.operations.Operation; +import org.apache.flink.table.operations.materializedtable.AlterMaterializedTableAsQueryOperation; +import org.apache.flink.table.operations.materializedtable.CreateMaterializedTableOperation; +import org.apache.flink.table.planner.operations.converters.table.MergeTableAsUtil; +import org.apache.flink.table.planner.utils.MaterializedTableUtils; + +import org.apache.calcite.sql.SqlNode; +import org.apache.calcite.sql.SqlNodeList; + +import java.util.ArrayList; +import java.util.HashSet; +import java.util.List; +import java.util.Map; +import java.util.Optional; +import java.util.Set; + +/** A converter for {@link SqlCreateOrAlterMaterializedTable}. */ +public class SqlCreateOrAlterMaterializedTableConverter + extends AbstractCreateMaterializedTableConverter<SqlCreateOrAlterMaterializedTable> { + + @Override + public Operation convertSqlNode( + SqlCreateOrAlterMaterializedTable sqlCreateOrAlterMaterializedTable, + ConvertContext context) { + final ObjectIdentifier identifier = + this.getIdentifier(sqlCreateOrAlterMaterializedTable, context); + return sqlCreateOrAlterMaterializedTable.isOrAlter() && tableExists(context, identifier) + ? handleAlter(sqlCreateOrAlterMaterializedTable, context) + : handleCreate(sqlCreateOrAlterMaterializedTable, context, identifier); + } + + private Operation handleAlter( + SqlCreateOrAlterMaterializedTable sqlCreateOrAlterMaterializedTable, + ConvertContext context) { + final ObjectIdentifier identifier = + this.getIdentifier(sqlCreateOrAlterMaterializedTable, context); + final ResolvedCatalogMaterializedTable oldTable = + getExistingResolvedMaterializedTable(context, identifier); + + final CatalogMaterializedTable newTable = + buildNewCatalogMaterializedTableFromOldTable( + oldTable, sqlCreateOrAlterMaterializedTable, context); + + List<MaterializedTableChange> tableChanges = + buildTableChanges(sqlCreateOrAlterMaterializedTable, oldTable, context); + + return new AlterMaterializedTableAsQueryOperation(identifier, tableChanges, newTable); + } + + private Operation handleCreate( + SqlCreateOrAlterMaterializedTable sqlCreateOrAlterMaterializedTable, + ConvertContext context, + ObjectIdentifier identifier) { + final ResolvedCatalogMaterializedTable resolvedCatalogMaterializedTable = + this.getResolvedCatalogMaterializedTable( + sqlCreateOrAlterMaterializedTable, context); + + return new CreateMaterializedTableOperation(identifier, resolvedCatalogMaterializedTable); + } + + private List<MaterializedTableChange> buildTableChanges( + SqlCreateOrAlterMaterializedTable sqlCreateOrAlterMaterializedTable, + ResolvedCatalogMaterializedTable oldTable, + ConvertContext context) { + List<MaterializedTableChange> changes = new ArrayList<>(); + final MergeContext mergeContext = + this.getMergeContext(sqlCreateOrAlterMaterializedTable, context); + + // Extract new columns + ResolvedSchema oldSchema = oldTable.getResolvedSchema(); + List<Column> newColumns = + MaterializedTableUtils.validateAndExtractNewColumns( + oldSchema, mergeContext.getMergedQuerySchema()); + + newColumns.forEach(column -> changes.add(TableChange.add(column))); + changes.add(TableChange.modifyDefinitionQuery(mergeContext.getMergedExpandedQuery())); + + return changes; + } + + private ResolvedCatalogMaterializedTable getExistingResolvedMaterializedTable( + ConvertContext context, ObjectIdentifier identifier) { + ResolvedCatalogBaseTable<?> baseTable = + context.getCatalogManager().getTableOrError(identifier).getResolvedTable(); + if (TableKind.MATERIALIZED_TABLE != baseTable.getTableKind()) { + throw new ValidationException( + "Only materialized table support modify definition query."); + } + return (ResolvedCatalogMaterializedTable) baseTable; + } + + private boolean tableExists(ConvertContext context, ObjectIdentifier identifier) { + return context.getCatalogManager().getTable(identifier).isPresent(); + } Review Comment: not sure we need this method at all given the fact that there is `getExistingResolvedMaterializedTable` moreover `tableExists` doesn't check table type ########## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/converters/SqlCreateOrAlterMaterializedTableConverter.java: ########## @@ -0,0 +1,262 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.planner.operations.converters; + +import org.apache.flink.sql.parser.ddl.SqlCreateOrAlterMaterializedTable; +import org.apache.flink.sql.parser.ddl.SqlTableColumn.SqlRegularColumn; +import org.apache.flink.table.api.Schema; +import org.apache.flink.table.api.ValidationException; +import org.apache.flink.table.catalog.CatalogBaseTable.TableKind; +import org.apache.flink.table.catalog.CatalogMaterializedTable; +import org.apache.flink.table.catalog.CatalogMaterializedTable.LogicalRefreshMode; +import org.apache.flink.table.catalog.CatalogMaterializedTable.RefreshMode; +import org.apache.flink.table.catalog.CatalogMaterializedTable.RefreshStatus; +import org.apache.flink.table.catalog.Column; +import org.apache.flink.table.catalog.IntervalFreshness; +import org.apache.flink.table.catalog.ObjectIdentifier; +import org.apache.flink.table.catalog.ResolvedCatalogBaseTable; +import org.apache.flink.table.catalog.ResolvedCatalogMaterializedTable; +import org.apache.flink.table.catalog.ResolvedSchema; +import org.apache.flink.table.catalog.TableChange; +import org.apache.flink.table.catalog.TableChange.MaterializedTableChange; +import org.apache.flink.table.catalog.TableDistribution; +import org.apache.flink.table.operations.Operation; +import org.apache.flink.table.operations.materializedtable.AlterMaterializedTableAsQueryOperation; +import org.apache.flink.table.operations.materializedtable.CreateMaterializedTableOperation; +import org.apache.flink.table.planner.operations.converters.table.MergeTableAsUtil; +import org.apache.flink.table.planner.utils.MaterializedTableUtils; + +import org.apache.calcite.sql.SqlNode; +import org.apache.calcite.sql.SqlNodeList; + +import java.util.ArrayList; +import java.util.HashSet; +import java.util.List; +import java.util.Map; +import java.util.Optional; +import java.util.Set; + +/** A converter for {@link SqlCreateOrAlterMaterializedTable}. */ +public class SqlCreateOrAlterMaterializedTableConverter + extends AbstractCreateMaterializedTableConverter<SqlCreateOrAlterMaterializedTable> { + + @Override + public Operation convertSqlNode( + SqlCreateOrAlterMaterializedTable sqlCreateOrAlterMaterializedTable, + ConvertContext context) { + final ObjectIdentifier identifier = + this.getIdentifier(sqlCreateOrAlterMaterializedTable, context); + return sqlCreateOrAlterMaterializedTable.isOrAlter() && tableExists(context, identifier) + ? handleAlter(sqlCreateOrAlterMaterializedTable, context) + : handleCreate(sqlCreateOrAlterMaterializedTable, context, identifier); + } + + private Operation handleAlter( + SqlCreateOrAlterMaterializedTable sqlCreateOrAlterMaterializedTable, + ConvertContext context) { + final ObjectIdentifier identifier = + this.getIdentifier(sqlCreateOrAlterMaterializedTable, context); + final ResolvedCatalogMaterializedTable oldTable = + getExistingResolvedMaterializedTable(context, identifier); + + final CatalogMaterializedTable newTable = + buildNewCatalogMaterializedTableFromOldTable( + oldTable, sqlCreateOrAlterMaterializedTable, context); + + List<MaterializedTableChange> tableChanges = + buildTableChanges(sqlCreateOrAlterMaterializedTable, oldTable, context); + + return new AlterMaterializedTableAsQueryOperation(identifier, tableChanges, newTable); + } + + private Operation handleCreate( + SqlCreateOrAlterMaterializedTable sqlCreateOrAlterMaterializedTable, + ConvertContext context, + ObjectIdentifier identifier) { + final ResolvedCatalogMaterializedTable resolvedCatalogMaterializedTable = + this.getResolvedCatalogMaterializedTable( + sqlCreateOrAlterMaterializedTable, context); + + return new CreateMaterializedTableOperation(identifier, resolvedCatalogMaterializedTable); + } + + private List<MaterializedTableChange> buildTableChanges( + SqlCreateOrAlterMaterializedTable sqlCreateOrAlterMaterializedTable, + ResolvedCatalogMaterializedTable oldTable, + ConvertContext context) { + List<MaterializedTableChange> changes = new ArrayList<>(); + final MergeContext mergeContext = + this.getMergeContext(sqlCreateOrAlterMaterializedTable, context); + + // Extract new columns + ResolvedSchema oldSchema = oldTable.getResolvedSchema(); + List<Column> newColumns = + MaterializedTableUtils.validateAndExtractNewColumns( + oldSchema, mergeContext.getMergedQuerySchema()); + + newColumns.forEach(column -> changes.add(TableChange.add(column))); + changes.add(TableChange.modifyDefinitionQuery(mergeContext.getMergedExpandedQuery())); + + return changes; + } + + private ResolvedCatalogMaterializedTable getExistingResolvedMaterializedTable( + ConvertContext context, ObjectIdentifier identifier) { + ResolvedCatalogBaseTable<?> baseTable = + context.getCatalogManager().getTableOrError(identifier).getResolvedTable(); + if (TableKind.MATERIALIZED_TABLE != baseTable.getTableKind()) { + throw new ValidationException( + "Only materialized table support modify definition query."); + } + return (ResolvedCatalogMaterializedTable) baseTable; + } + + private boolean tableExists(ConvertContext context, ObjectIdentifier identifier) { + return context.getCatalogManager().getTable(identifier).isPresent(); + } + + private CatalogMaterializedTable buildNewCatalogMaterializedTableFromOldTable( Review Comment: ideally this method should be in alterMaterializedTable converter may be we can move it in future when that converter becomes more mature -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
