snuyanzin commented on code in PR #27199:
URL: https://github.com/apache/flink/pull/27199#discussion_r2523911929
##########
flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlCreateMaterializedTable.java:
##########
@@ -102,7 +101,7 @@ public SqlCreateMaterializedTable(
@Override
public SqlOperator getOperator() {
- return OPERATOR;
+ return CREATE_OPERATOR;
}
Review Comment:
I guess if you drop this method override it will return the operator which
is passed to the constructor and this is what we want, right?
##########
flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlCreateOrAlterMaterializedTable.java:
##########
@@ -0,0 +1,160 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.sql.parser.ddl;
+
+import org.apache.flink.sql.parser.SqlUnparseUtils;
+import org.apache.flink.sql.parser.ddl.constraint.SqlTableConstraint;
+
+import org.apache.calcite.sql.SqlCharStringLiteral;
+import org.apache.calcite.sql.SqlIdentifier;
+import org.apache.calcite.sql.SqlIntervalLiteral;
+import org.apache.calcite.sql.SqlKind;
+import org.apache.calcite.sql.SqlNode;
+import org.apache.calcite.sql.SqlNodeList;
+import org.apache.calcite.sql.SqlOperator;
+import org.apache.calcite.sql.SqlSpecialOperator;
+import org.apache.calcite.sql.SqlWriter;
+import org.apache.calcite.sql.parser.SqlParserPos;
+
+import javax.annotation.Nullable;
+
+import java.util.List;
+
+/** CREATE [OR ALTER] MATERIALIZED TABLE DDL sql call. */
+public class SqlCreateOrAlterMaterializedTable extends
SqlCreateMaterializedTable {
+
+ public static final SqlSpecialOperator CREATE_OR_ALTER_OPERATOR =
+ new SqlSpecialOperator("CREATE OR ALTER MATERIALIZED TABLE",
SqlKind.OTHER_DDL);
+
+ private final boolean isOrAlter;
+
+ public SqlCreateOrAlterMaterializedTable(
+ SqlParserPos pos,
+ SqlIdentifier tableName,
+ SqlNodeList columnList,
+ List<SqlTableConstraint> tableConstraints,
+ SqlWatermark watermark,
+ @Nullable SqlCharStringLiteral comment,
+ @Nullable SqlDistribution distribution,
+ SqlNodeList partitionKeyList,
+ SqlNodeList propertyList,
+ @Nullable SqlIntervalLiteral freshness,
+ @Nullable SqlRefreshMode refreshMode,
+ SqlNode asQuery,
+ boolean isOrAlter) {
+ super(
+ isOrAlter ? CREATE_OR_ALTER_OPERATOR : CREATE_OPERATOR,
+ pos,
+ tableName,
+ columnList,
+ tableConstraints,
+ watermark,
+ comment,
+ distribution,
+ partitionKeyList,
+ propertyList,
+ freshness,
+ refreshMode,
+ asQuery);
+ this.isOrAlter = isOrAlter;
+ }
+
+ @Override
+ public SqlOperator getOperator() {
+ return isOrAlter ? CREATE_OR_ALTER_OPERATOR : CREATE_OPERATOR;
+ }
Review Comment:
probably no need for this method if already passed operator to constructor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
