fapaul commented on code in PR #26662:
URL: https://github.com/apache/flink/pull/26662#discussion_r2158395941
##########
flink-formats/flink-avro-confluent-registry/src/test/java/org/apache/flink/formats/avro/registry/confluent/RegistryAvroFormatFactoryTest.java:
##########
@@ -229,6 +229,74 @@ public void
testSerializationSchemaWithInvalidOptionalSchema() {
null, SCHEMA.toPhysicalRowDataType()));
}
+ @Test
Review Comment:
Nit: Can we turn the three (or at least the first/third) tests into a
`parameterizedTest` to avoid the code duplication?
It's a bit unclear to me why only test two verifies the behavior for sinks
and sources while the other tests only look at sinks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
