davidradl commented on code in PR #26662:
URL: https://github.com/apache/flink/pull/26662#discussion_r2139526384
##########
flink-formats/flink-avro-confluent-registry/src/main/java/org/apache/flink/formats/avro/registry/confluent/ConfluentSchemaRegistryCoder.java:
##########
@@ -58,7 +77,7 @@ public ConfluentSchemaRegistryCoder(String subject,
SchemaRegistryClient schemaR
* @param schemaRegistryClient client to connect schema registry
*/
public ConfluentSchemaRegistryCoder(SchemaRegistryClient
schemaRegistryClient) {
- this.schemaRegistryClient = schemaRegistryClient;
+ this(null, schemaRegistryClient, null);
Review Comment:
nit: it is a bit strange to have an optional first parameter I would expect
the mandatory parameters first for all these methods ie the constructors to all
start
`ConfluentSchemaRegistryCoder(SchemaRegistryClient schemaRegistryClient` ...
I realise this is existing code, so it is your call if you want to change it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
