wenjin272 commented on code in PR #6: URL: https://github.com/apache/flink-agents/pull/6#discussion_r2139737737
########## python/flink_agents/plan/workflow_plan.py: ########## @@ -0,0 +1,51 @@ +################################################################################ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +################################################################################# + +from typing import Dict, List, Type + +from pydantic import BaseModel + +from flink_agents.api.event import Event +from flink_agents.plan.action import Action + + +class WorkflowPlan(BaseModel): + """Workflow plan compiled from user defined workflow. + + Attributes: + ---------- + actions : Dict[Type[Event], List[Action]] + Mapping of event types to the list of Actions that listen to them. + """ + + actions: Dict[Type[Event], List[Action]] + + def get_action(self, event_type: Type[Event]) -> List[Action]: + """Get steps that listen to the specified event type. Review Comment: yes, thank you xu. ########## python/flink_agents/plan/action.py: ########## @@ -0,0 +1,45 @@ +################################################################################ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +################################################################################# + +from typing import List, Type + +from pydantic import BaseModel + +from flink_agents.api.event import Event +from flink_agents.plan.function import Function + + +class Action(BaseModel): + """Representation of a workflow action with event listening and function execution. + + This class encapsulates a named workflow action that listens for specific event + types and executes an associated function when those events occur. + + Attributes: + ---------- + name : str + Name/identifier of the workflow Action. + exec : Function + To be executed when the Action is triggered. + listen_event_types : List[Type[Event]] + List of event types that will trigger this Action's execution. + """ + + name: str + exec: Function Review Comment: I add a func signature check logic when init one Action, and the check logic will be corrected after we import State and RunnerContext. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
