xintongsong commented on code in PR #6: URL: https://github.com/apache/flink-agents/pull/6#discussion_r2139120055
########## python/flink_agents/plan/function.py: ########## @@ -0,0 +1,102 @@ +################################################################################ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +################################################################################# + +import importlib +import inspect +from typing import Any, Callable, Dict, Tuple + +from pydantic import BaseModel + + +class Function(BaseModel): + """Descriptor for a callable function, storing module and qualified name for dynamic + retrieval. + + This class allows serialization and lazy loading of functions by storing their + module and + qualified name. The actual callable is loaded on-demand when the instance is called. + + Attributes: + ---------- + module : str + Name of the Python module where the function is defined. + qualname : str + Qualified name of the function (e.g., 'ClassName.method' for class methods). + __func: Callable + Internal cache for the resolved function Review Comment: Private property should not be documented here. ########## python/flink_agents/plan/action.py: ########## @@ -0,0 +1,45 @@ +################################################################################ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +################################################################################# + +from typing import List, Type + +from pydantic import BaseModel + +from flink_agents.api.event import Event +from flink_agents.plan.function import Function + + +class Action(BaseModel): + """Representation of a workflow action with event listening and function execution. + + This class encapsulates a named workflow action that listens for specific event + types and executes an associated function when those events occur. + + Attributes: + ---------- + name : str + Name/identifier of the workflow Action. + exec : Function + To be executed when the Action is triggered. + listen_event_types : List[Type[Event]] + List of event types that will trigger this Action's execution. + """ + + name: str + exec: Function Review Comment: Shall we check the signature of the function to make sure it's a valid action? ########## python/flink_agents/plan/function.py: ########## @@ -0,0 +1,102 @@ +################################################################################ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +################################################################################# + +import importlib +import inspect +from typing import Any, Callable, Dict, Tuple + +from pydantic import BaseModel + + +class Function(BaseModel): Review Comment: I think this should be PythonFunction, and we need another Function as a common abstraction of Python & Java functions. ########## python/flink_agents/plan/tests/test_workflow_plan.py: ########## @@ -0,0 +1,47 @@ +################################################################################ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +################################################################################# + +from flink_agents.api.event import InputEvent, OutputEvent +from flink_agents.plan.action import Action +from flink_agents.plan.function import Function +from flink_agents.plan.workflow_plan import WorkflowPlan + + +def increment(event: InputEvent) -> OutputEvent: # noqa: D103 + value = event.input + value += 1 + return OutputEvent(isLegal=True, result=value) Review Comment: This doesn't look right. It assumes an action can only emit one event, as the return value, which is incorrect. ########## python/flink_agents/plan/function.py: ########## @@ -0,0 +1,102 @@ +################################################################################ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +################################################################################# + +import importlib +import inspect +from typing import Any, Callable, Dict, Tuple + +from pydantic import BaseModel + + +class Function(BaseModel): + """Descriptor for a callable function, storing module and qualified name for dynamic + retrieval. + + This class allows serialization and lazy loading of functions by storing their + module and Review Comment: Odd line break here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
