XComp commented on code in PR #25218: URL: https://github.com/apache/flink/pull/25218#discussion_r2085026252
########## flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adaptive/allocator/SlotSharingSlotAllocatorTest.java: ########## @@ -62,6 +62,8 @@ class SlotSharingSlotAllocatorTest { private static final IsSlotAvailableAndFreeFunction TEST_IS_SLOT_FREE_FUNCTION = ignored -> true; private static final boolean DISABLE_LOCAL_RECOVERY = false; + private static final String NULL_EXECUTION_TARGET = null; + private static final boolean MINIMAL_TASK_MANAGER_PREFERRED = false; Review Comment: yes, `MINIMAL_TASK_MANAGER_PREFERRED` reads as if it's "preferred", i.e. enabled. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org