ruanhang1993 commented on PR #4004: URL: https://github.com/apache/flink-cdc/pull/4004#issuecomment-2939029764
> I agree with you in general. Maybe only a minor discuss on option name. What about `scan.publish-via-partition-root.enabled`? @leonardBang @ruanhang1993 , WDYT? > > ``` > <td>include-partitioned-table</td> > <td>optional</td> > <td style="word-wrap: break-word;">false</td> > <td>Boolean</td> > <td> > Whether to enable reading partitioned table.<br> > If enabled: > (1) PUBLICATION must be created beforehand with parameter publish_via_partition_root=true > (2) Table list (regex or predefined list) should only match the parent table name, if table list matches both parent and child tables, snapshot data will be read twice. > </td> > </tr> > ``` Hi, @phamvinh1712 @loserwang1024 .Sorry for my late response. IMO, I think this new option name `scan.publish-via-partition-root.enabled` is difficult to understand for users who are not familiar with postgres. Actually I am one of them. ;) The first time I saw this option name, I was confused and do not know when I should open this option. I think the option name could be like `scan.include-partitioned-tables.enabled`. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
