darenwkt commented on code in PR #203:
URL:
https://github.com/apache/flink-connector-aws/pull/203#discussion_r2061246676
##########
flink-connector-aws/flink-connector-dynamodb/src/test/java/org/apache/flink/connector/dynamodb/table/RowDataToAttributeValueConverterTest.java:
##########
@@ -216,7 +216,7 @@ void testFloat() {
Map<String, AttributeValue> actualResult =
rowDataToAttributeValueConverter.convertRowData(createElement(value));
Map<String, AttributeValue> expectedResult =
- singletonMap(key,
AttributeValue.builder().n("1.23456791E17").build());
+ singletonMap(key,
AttributeValue.builder().n("1.2345679E17").build());
Review Comment:
Updating this test case as it failed locally when I ran it with Java version
8.0.432-amzn (Corretto) due to Java floating point number precision only
accurate up to 6-7 digits decimal place.
##########
flink-connector-aws/flink-connector-dynamodb/src/test/java/org/apache/flink/connector/dynamodb/table/RowDataToAttributeValueConverterTest.java:
##########
@@ -216,7 +216,7 @@ void testFloat() {
Map<String, AttributeValue> actualResult =
rowDataToAttributeValueConverter.convertRowData(createElement(value));
Map<String, AttributeValue> expectedResult =
- singletonMap(key,
AttributeValue.builder().n("1.23456791E17").build());
+ singletonMap(key,
AttributeValue.builder().n("1.2345679E17").build());
Review Comment:
Updated this test case as it failed locally when I ran it with Java version
8.0.432-amzn (Corretto) due to Java floating point number precision only
accurate up to 6-7 digits decimal place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
