darenwkt opened a new pull request, #203: URL: https://github.com/apache/flink-connector-aws/pull/203
<!-- *Thank you for contributing to Apache Flink AWS Connectors - we are happy that you want to help us improve our Flink connectors. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.* ## Contribution Checklist - The name of the pull request should correspond to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue. - Commits should be in the form of "[FLINK-XXXX][component] Title of the pull request", where [FLINK-XXXX] should be replaced by the actual issue number. Generally, [component] should be the connector you are working on. For example: "[FLINK-XXXX][Connectors/Kinesis] XXXX" if you are working on the Kinesis connector or "[FLINK-XXXX][Connectors/AWS] XXXX" if you are working on components shared among all the connectors. - Each pull request should only have one JIRA issue. - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below. --> ## Purpose of the change [FLINK-37733] Externalise DynamoDB connector IT Test to E2E test package - DynamoDB connector IT Test currently resides in `flink-connector-dynamodb` package which means: - It is inconsistent with other connector package where IT test resides in their own e2e test package. - Building the package takes longer as IT test takes time to spin up a docker environment for the test. - Github action/workflow does not run the IT test as they are not in e2e test package. - This is a minor improvement to relocate the IT test into its own e2e test package similar to other connectors ## Verifying this change Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing - This change is a trivial rework / code cleanup without any test coverage as it just relocates existing IT test to a new E2E test package - Verified the e2e test passes as follows: - Run `mvn clean verify -Prun-end-to-end-tests -DdistDir=/Users/Downloads/flink-1.19.2` ``` [INFO] ------------------------------------------------------- [INFO] T E S T S [INFO] ------------------------------------------------------- [INFO] Running org.apache.flink.connector.dynamodb.sink.test.DynamoDbSinkITCase [INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 114.11 s - in org.apache.flink.connector.dynamodb.sink.test.DynamoDbSinkITCase [INFO] Running org.apache.flink.connector.dynamodb.table.test.DynamoDbDynamicSinkITCase [INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 52.551 s - in org.apache.flink.connector.dynamodb.table.test.DynamoDbDynamicSinkITCase [INFO] [INFO] Results: [INFO] [INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 02:49 min ``` ## Significant changes *(Please check any boxes [x] if the answer is "yes". You can first publish the PR and check them afterwards, for convenience.)* - [ ] Dependencies have been added or upgraded - [ ] Public API has been changed (Public API is any class annotated with `@Public(Evolving)`) - [ ] Serializers have been changed - [ ] New feature has been introduced - If yes, how is this documented? (not applicable / docs / JavaDocs / not documented) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
