Mrart commented on code in PR #3950:
URL: https://github.com/apache/flink-cdc/pull/3950#discussion_r2013146979
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-cdc-base/src/main/java/org/apache/flink/cdc/connectors/base/config/JdbcSourceConfigFactory.java:
##########
@@ -208,6 +208,7 @@ public JdbcSourceConfigFactory
startupOptions(StartupOptions startupOptions) {
case INITIAL:
case SNAPSHOT:
case LATEST_OFFSET:
+ case COMMITTED_OFFSETS:
Review Comment:
Instead of COMMITED_OFFSETS, I think we should stick with specified-offset,
for example: "scan.startup.specific-offset.lsn"="0/70AF43F8".As
scan.startup.specific-offset.lsn=‘committed’，lsn will read from db. We thought
we'd implement the cdc connector with as few modifications to base as possible
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-postgres-cdc/src/main/java/org/apache/flink/cdc/connectors/postgres/source/PostgresDialect.java:
##########
@@ -140,6 +141,17 @@ public Offset displayCurrentOffset(JdbcSourceConfig
sourceConfig) {
}
}
+ public Offset displayCommittedOffset(JdbcSourceConfig sourceConfig) {
Review Comment:
We need some test case coverage？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
