phamvinh1712 commented on code in PR #3950:
URL: https://github.com/apache/flink-cdc/pull/3950#discussion_r2053051726


##########
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-postgres-cdc/src/test/java/org/apache/flink/cdc/connectors/postgres/table/PostgreSQLConnectorITCase.java:
##########
@@ -261,6 +261,110 @@ void testStartupFromLatestOffset(boolean 
parallelismSnapshot) throws Exception {
         result.getJobClient().get().cancel().get();
     }
 
+    @ParameterizedTest
+    @ValueSource(booleans = {true})
+    public void testStartupFromCommittedOffset(boolean parallelismSnapshot) 
throws Exception {
+        setup(parallelismSnapshot);
+        initializePostgresTable(POSTGRES_CONTAINER, "inventory");
+

Review Comment:
   @loserwang1024 this test does exactly what you described:
   - There are 2 job runs in the test:
     - The first job starts, create the replication slot, receives 2 events 
then stopped.
     - Then 1 record is inserted to database during the job stopped
     - Second job starts without resuming from checkpoint, it will pick up the 
1 record that inserted after the job stopped. Without this committed-offset 
mode, it won't consume this record.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to